Skip to content

feat: URL resolving support for validate & metaschema #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
robbat2 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: URL resolving support for validate & metaschema #605

robbat2 wants to merge 1 commit into from

Conversation

@robbat2
Copy link
Contributor

@robbat2 robbat2 commented Jan 10, 2026

Closes: #234
Co-authored-by: Codex [email protected]
Generated-with: OpenAI Codex CLI (partial)
Signed-off-by: Robin H. Johnson [email protected]

@robbat2 robbat2 force-pushed the rjohnson/http-fetch-validate branch from 050993e to eca24c0 Compare January 10, 2026 16:04
@robbat2
Copy link
Contributor Author

robbat2 commented Jan 10, 2026

Interesting heisenbug failure - the URL is fine, but it had a 404 when the test ran?

435/451 Test #435: JSONSchema.ci.fail_bundle_http_non_schema_verbose .............................***Failed    0.60 sec
2,3c2,5
< error: HTTP 404
<   at https://schemas.sourcemeta.com/self/v1/api/schemas/stats/jsonschema/2020-12/schema
---
> error: The JSON document is not a valid JSON Schema
>   at identifier https://schemas.sourcemeta.com/self/v1/api/schemas/stats/jsonschema/2020-12/schema
>   at file path /tmp/tmp.psSZLWYWpc/schema.json
>   at location "/allOf/0/$ref"

        Start 439: JSONSchema.ci.fail_validate_http_non_schema_verbose
436/451 Test #431: JSONSchema.ci.pass_bundle_http ................................................   Passed    0.74 sec

@jviotti
Copy link
Member

jviotti commented Jan 13, 2026

Interesting feature! Thanks for sending it. I'll book some time today to properly review it 🙏🏻

jviotti
jviotti requested changes Jan 14, 2026
View reviewed changes
Copy link
Member

@jviotti jviotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the idea. I think the way Codex/you are implementing it is fighting the current machinery for iterating on schema arguments. I think we need for make for_each_json transparently work with both URLs or file paths. The src/input.h file abstracts a way a lot of the logic, including line number gathering, reading, etc so that the actual commands never have to worry about it.

for_each_json will loop and pass specific positional arguments to handle_json_entry. It feels to me that such handle_json_entry needs to take either a path or a URI (maybe just a string?) and then internally check: if it is a path and it exists and it is a file, do X, if it is a directory, do Y, if it is an HTTP/S URL, do Z.

I think if we do all of that there, we very elegantly gain URL support in every applicable command.

@jviotti
Copy link
Member

jviotti commented Jan 14, 2026

On the transient CI failure, yeah, we've been getting that quite a bit recently. I'm on it right now!

@jviotti
Copy link
Member

jviotti commented Jan 14, 2026

If you merge main back in, the transient CI issue should be gone!

@robbat2 robbat2 force-pushed the rjohnson/http-fetch-validate branch 2 times, most recently from 6bf416d to 3d93e71 Compare January 14, 2026 20:35
@robbat2 robbat2 requested a review from jviotti January 14, 2026 20:40
@robbat2
feat: URL resolving support for validate & metaschema
7ced116 
Closes: sourcemeta#234
Co-authored-by: Codex <[email protected]>
Generated-with: OpenAI Codex CLI (partial)
Signed-off-by: Robin H. Johnson <[email protected]>
@robbat2 robbat2 force-pushed the rjohnson/http-fetch-validate branch from 3d93e71 to 7ced116 Compare January 14, 2026 20:43
@robbat2
Copy link
Contributor Author

robbat2 commented Jan 14, 2026

couple more CI bumps from the code but ready again; nothing transient this time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jviotti jviotti Awaiting requested review from jviotti

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Extend validate/metaschema to directly take a URL to a schema to validate

2 participants

@robbat2 @jviotti